@ExtremeFiretop,

BTW, I don't have permissions to merge a PR from develop to the master branch. Apparently, I need approval from the co-owner (i.e. you, while on vacation, LOL!!) to merge into the master branch. No big deal, so just an FYI.

@ExtremeFiretop,

BTW, I don't have permissions to merge a PR from develop to the master branch. Apparently, I need approval from the co-owner (i.e. you, while on vacation, LOL!!) to merge into the master branch. No big deal, so just an FYI.

Really? Since when! I was sure I set you up to be able to bypass any requirements as needed.

I'll have to double check this when I get back. Thank you for flagging this.

@ExtremeFiretop,
BTW, I don't have permissions to merge a PR from develop to the master branch. Apparently, I need approval from the co-owner (i.e. you, while on vacation, LOL!!) to merge into the master branch. No big deal, so just an FYI.

Really? Since when! I was sure I set you up to be able to bypass any requirements as needed.

I honestly don't know. I don't think I've ever tried to merge a PR from develop to the master branch because you've always been available for review, and you make the final decision to issue the production releases once we're satisfied with the latest fixes and changes.

I'll have to double check this when I get back. Thank you for flagging this.

OK, sounds good. As mentioned, it's not a biggie, so take your time.

Now, go back to the beach and enjoy the sun and the sand (while watching all the girls in bikinis, LOL!!!), with a margarita.

@ExtremeFiretop,

Sigh!!! Sorry to bother you, bud... But I'm back to not being able to merge this PR into the master branch because I updated the README file for the production release. So if you happen to check your phone, please approve the changes again at your convenience.

@ExtremeFiretop,

Sigh!!! Sorry to bother you, bud... But I'm back to not being able to merge this PR into the master branch because I updated the README file for the production release. So if you happen to check your phone, please approve the changes again at your convenience.

That is both hilarious and a bit sad at the same time 😂 we really need to fix this, sadly looking through the options on my phone with slow Internet is not proving to be ideal, but I'm back in Canada tomorrow so we'll discuss the solutions to give you control more then.

Until then I've approved this PR! Ready to go!

@ExtremeFiretop,
Sigh!!! Sorry to bother you, bud... But I'm back to not being able to merge this PR into the master branch because I updated the README file for the production release. So if you happen to check your phone, please approve the changes again at your convenience.

...

That is both hilarious and a bit sad at the same time 😂 we really need to fix this, sadly looking through the options on my phone with slow Internet is not proving to be ideal, but I'm back in Canada tomorrow so we'll discuss the solutions to give you control more then.

I know, right? LOL!! It was a mistake on my part. I was modifying all the README files for the releases I was planning to make yesterday evening, and after committing the file for MerlinAU, it dawned on me that I needed the approval again. It was a silly mistake.

I hope your flight back to Canada went well, and you and your partner are back safe and sound.

Until then I've approved this PR! Ready to go!

Thank you. And again, my apologies for interrupting your vacation.

I know, right? LOL!! It was a mistake on my part. I was modifying all the README files for the releases I was planning to make yesterday evening, and after committing the file for MerlinAU, it dawned on me that I needed the approval again. It was a silly mistake.

Questioning whether or not you have the ability to approve the code review from your end?

It says it's stuck waiting for a code review from a reviewer with write access. Your a code owner in the file so can you review and "approve" your own PR? What happens when you try?

I hope your flight back to Canada went well, and you and your partner are back safe and sound.

I'm looking forwards to returning. I get a little home sick quickly.
I'm just hoping my ears survive the flight back!

Until then I've approved this PR! Ready to go!

Thank you. And again, my apologies for interrupting your vacation.

No worries at all, no interruption. I wake up and check under my own accord when I have a moment, I don't feel like I'm being bothered one bit. I appreciate you stepping in.

@Martinski4GitHub

Alternatively, do you see the option for:

"Merge without waiting for requirements to be met (bypass rules)"? It would normally be above the option to enable or disable auto-merge.

I know, right? LOL!! It was a mistake on my part. I was modifying all the README files for the releases I was planning to make yesterday evening, and after committing the file for MerlinAU, it dawned on me that I needed the approval again. It was a silly mistake.

Questioning whether or not you have the ability to approve the code review from your end?

It says it's stuck waiting for a code review from a reviewer with write access. Your a code owner in the file so can you review and "approve" your own PR? What happens when you try?

I can review and approve ONLY for the develop branch. No such permissions for the master branch.

I hope your flight back to Canada went well, and you and your partner are back safe and sound.

I'm looking forwards to returning. I get a little home sick quickly. I'm just hoping my ears survive the flight back!

Oh yeah, the ears popping during the flight. I usually chew gum to avoid that - it works most of the time.

Until then I've approved this PR! Ready to go!

Thank you. And again, my apologies for interrupting your vacation.

No worries at all, no interruption. I wake up and check under my own accord when I have a moment, I don't feel like I'm being bothered one bit. I appreciate you stepping in.

OK, good. I tend to do the same when we're on vacation, but I respond only if it's an urgent message from work or a family situation. I really try to "unplug" as much as possible.

@Martinski4GitHub

Alternatively, do you see the option for:

"Merge without waiting for requirements to be met (bypass rules)"? It would normally be above the option to enable or disable auto-merge.

Not at all. I see that option available only for the OSR repos as shown below, but not for MerlinAU:

@Martinski4GitHub
Alternatively, do you see the option for:
"Merge without waiting for requirements to be met (bypass rules)"? It would normally be above the option to enable or disable auto-merge.

Not at all. I see that option available only for the OSR repos as shown below, but not for MerlinAU:

I loosened the restrictions around the main branch just now and then resent you an invitation to collaborate, hopefully that will solve it going forwards.

I guess we won't really know until we try and test with another PR against main at some point.

@Martinski4GitHub
Alternatively, do you see the option for:
"Merge without waiting for requirements to be met (bypass rules)"? It would normally be above the option to enable or disable auto-merge.

Not at all. I see that option available only for the OSR repos as shown below, but not for MerlinAU:

I loosened the restrictions around the main branch just now and then resent you an invitation to collaborate, hopefully that will solve it going forwards.

OK, sounds good. I've accepted the invitation, so we'll see what happens next time.

I guess we won't really know until we try and test with another PR against main at some point.

Yep, crossing fingers!!! 🤞😉

@Martinski4GitHub
Alternatively, do you see the option for:
"Merge without waiting for requirements to be met (bypass rules)"? It would normally be above the option to enable or disable auto-merge.

Not at all. I see that option available only for the OSR repos as shown below, but not for MerlinAU:

I loosened the restrictions around the main branch just now and then resent you an invitation to collaborate, hopefully that will solve it going forwards.

OK, sounds good. I've accepted the invitation, so we'll see what happens next time.

I guess we won't really know until we try and test with another PR against main at some point.

Yep, crossing fingers!!! 🤞😉

For documentation purposes.

I tried to disabled: "Require review from Code Owners" Within the ruleset.

You are a code owner in the code owners file. So not sure why would be a problem but I tried that.

Also added a bypass for anyone with "maintainer" or "write" access.

Hopefully between both those changes it should work. I'm just going based on the error in the screenshot you sent for now.

And according to Githubs own verification the codeowners file (set over a year ago!) is valid:

I loosened the restrictions around the main branch just now and then resent you an invitation to collaborate, hopefully that will solve it going forwards.

OK, sounds good. I've accepted the invitation, so we'll see what happens next time.

I guess we won't really know until we try and test with another PR against main at some point.

Yep, crossing fingers!!! 🤞😉

For documentation purposes.

I tried to disabled: "Require review from Code Owners" Within the ruleset.

You are a code owner in the code owners file. So not sure why would be a problem but I tried that.

Also added a bypass for anyone with "maintainer" or "write" access.

Hopefully between both those changes it should work. I'm just going based on the error in the screenshot you sent for now.

Yes, it works now. I was able to submit and merge a PR with an innocuous change in the README file. The required review and approval can be skipped with the option to "Bypass rules and merge."
Excellent work, bud!!!

I loosened the restrictions around the main branch just now and then resent you an invitation to collaborate, hopefully that will solve it going forwards.

OK, sounds good. I've accepted the invitation, so we'll see what happens next time.

I guess we won't really know until we try and test with another PR against main at some point.

Yep, crossing fingers!!! 🤞😉

For documentation purposes.
I tried to disabled: "Require review from Code Owners" Within the ruleset.
You are a code owner in the code owners file. So not sure why would be a problem but I tried that.
Also added a bypass for anyone with "maintainer" or "write" access.
Hopefully between both those changes it should work. I'm just going based on the error in the screenshot you sent for now.

Yes, it works now. I was able to submit and merge a PR with an innocuous change in the README file. The required review and approval can be skipped with the option to "Bypass rules and merge." Excellent work, bud!!!

Perfection! Thanks for confirming! Happy we solved that mystery.

I wonder if that means the code owners file doesn't work the way I thought it did.

No matter, just happy you have a way to bypass our regular flow if required.

Goodnight bud and chat more after i land!